fix an improperly configured baseurl, which was causing links to have //#1
Open
maxthomas wants to merge 1 commit intoplumatic:masterfrom
Open
fix an improperly configured baseurl, which was causing links to have //#1maxthomas wants to merge 1 commit intoplumatic:masterfrom
maxthomas wants to merge 1 commit intoplumatic:masterfrom
Conversation
Member
|
Thanks! That link was actually broken due to the trailing slash in the link from the README (now fixed) -- it seems to accept one or two leading slashes with no problem. This change sounds like the right thing but I'm also a bit hesitant to mess with it since I think things are otherwise working. I'll leave this open and maybe loop back to it when I have more time to mess around. Thanks again! |
Author
|
cool, no worries. if you're rustling around in that <a name="fnk"/>
## Bring on (de)fnk as it stands it's not rendering properly (see here then find for |
Member
|
Fixed, thanks!
…On Wed, Apr 5, 2017 at 9:47 AM, max ***@***.***> wrote:
cool, no worries. if you're rustling around in that README.md you may
want to add a newline here as well:
<a name="fnk"/>
## Bring on (de)fnk
as it stands it's not rendering properly (see here
<https://github.com/plumatic/plumbing/blob/master/README.md> then find
for ##)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIPprJr509nnIvu06-woGbu_4ww5nCHks5rs8WSgaJpZM4M0ftF>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey there, was poking around on this library and wanted to see the linked strange loop post, but got a 404 from the link.
turns out i think jekyll is creating an extra
/character in links to posts on your site, e.g. the about link is:other posts:
etc. i'm not a jekyll expert but i'm guessing this isn't desired behavior!
i believe this is due to a misconfigured
baseurl, which this PR fixes. you can read more about this here. but basically since the blog is in the root path, you don't needbaseurl, it seems...